Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Fix multi-search with template doesn't return status code (#16265) #16312

Merged
merged 2 commits into from
Oct 15, 2024
Merged

[Backport 2.x] Fix multi-search with template doesn't return status code (#16265) #16312

merged 2 commits into from
Oct 15, 2024

Conversation

gaobinlong
Copy link
Collaborator

Description

Backport #16265 to 2.x.

Related Issues

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@gaobinlong
Fix multi-search with template doesn't return status code (opensearch…
4bc5a07 
…-project#16265)

* Fix multi-search with template doesn't return status code

Signed-off-by: Gao Binlong <[email protected]>

* Modify changelog

Signed-off-by: Gao Binlong <[email protected]>

---------

Signed-off-by: Gao Binlong <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 4bc5a07: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator

reta commented Oct 15, 2024 

* What went wrong:
Execution failed for task ':modules:lang-mustache:spotlessJavaCheck'.
> The following files had format violations:
      src/main/java/org/opensearch/script/mustache/MultiSearchTemplateResponse.java
          @@ -32,8 +32,8 @@
           
           package·org.opensearch.script.mustache;
           
          +import·org.opensearch.ExceptionsHelper;
           import·org.opensearch.LegacyESVersion;
          -import·org.opensearch.ExceptionsHelper;
           import·org.opensearch.OpenSearchException;
           import·org.opensearch.action.search.MultiSearchResponse;
           import·org.opensearch.common.Nullable;
  Run './gradlew :modules:lang-mustache:spotlessApply' to fix these violations.

@gaobinlong
Format the code
005338d 
Signed-off-by: Gao Binlong <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 005338d: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Oct 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.79%. Comparing base (5947002) to head (005338d).
Report is 11 commits behind head on 2.x.

Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #16312      +/-   ##
============================================
+ Coverage     71.74%   71.79%   +0.04%     
- Complexity    65022    65051      +29     
============================================
  Files          5302     5303       +1     
  Lines        303866   303858       -8     
  Branches      44192    44188       -4     
============================================
+ Hits         218012   218155     +143     
+ Misses        67648    67501     -147     
+ Partials      18206    18202       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbwiddis dbwiddis merged commit 00a03dc into opensearch-project:2.x Oct 15, 2024
39 checks passed
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Oct 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbwiddis dbwiddis dbwiddis approved these changes

@reta reta reta approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaobinlong @reta @dbwiddis